一种更简洁的方式来使用我的控制器方法

Question

我正在制作一个应用程序，将一个词从一种语言翻译成英语并获取有关它的信息（例如定义、在句子中的使用、同义词、声音表示）

我的功能是做什么的：

在数据库中搜索翻译。如果找到，我们 return 它。
如果找不到，我们会使用 google 翻译或 Yandex 翻译 API.
如果找到翻译，我们会下载它的声音表示，将翻译保存到数据库并添加其他 API 的
我们 return 包含所有信息的 json 回复。

现在我的控制器方法非常庞大，我找不到更简洁的方法来处理它。

感谢任何帮助。

public function store(Request $request)
{
    $translated = $request->get('translated');
    $translation = $this->translation->findBy('translated', $translated)->first();

    if ($translation) {
        return Response::json(['translation' => $this->translation->with(['examples', 'definitions', 'synonyms', 'images'])->find($translation->id)], ResponseCode::HTTP_CREATED);
    }

    $data = $request->all();
    $data['translation'] = $this->translate($translated);

    if ($translated == $data['translation']) {
        Log::info('Translation not found: ' . $data['translation']);
        return $this->translationNotFound();
    }

    $downloader = new Downloader(new GoogleSpeechDownloader());
    $filename = $downloader->download($data['translation']);

    if ($filename) $data['sound_name'] = $filename;

    $translation = $this->translation->create($data);

    $this->createDefinition($translation);
    $this->createExample($translation);
    $this->createSynonym($translation);

    return Response::json(['translation' => $this->translation->with(['examples', 'definitions', 'synonyms', 'images'])->find($translation->id)], ResponseCode::HTTP_CREATED);
}

private function translationNotFound()
{
    return Response::json(['error' => 'Vertimas nerastas.'], ResponseCode::HTTP_NOT_FOUND);
}

private function createDefinition($translation)
{
    $definition = new Definition();
    $definer = new Definer(new DictionaryApiDefiner());
    try {
        $definition->definition = $definer->getDefinition($translation->translation);
        $definition->approved = true;
        $translation->definitions()->save($definition);
    } catch (\Exception $e) {
        Log::alert('Definition for word ' . $translation->translation . ' not found.');
    }
}

private function createExample($translation)
{
    $example = new Example();
    $exampler = new ExampleCreator(new YourDictionaryGouteParserExampler());
    try {
        $example->example = $exampler->getExample($translation->translation);
        $example->approved = true;
        $translation->examples()->save($example);
    } catch (\Exception $e) {
        Log::alert('Example for word ' . $translation->translation . ' not found.');
    }
}

private function createSynonym($translation)
{
    $creator = new SynonymCreator(new BigHugeLabsSynonymCreator());
    foreach ($creator->getSynonyms($translation->translation) as $s) {
        $synonym = new Synonym();
        $synonym->synonym = $s;
        $synonym->approved = true;
        $translation->synonyms()->save($synonym);
    }
}

private function translate($translated)
{
    $translator = new Translator(new GoogleTranslator());

    try {
        return $translator->translate($translated);
    } catch (\Exception $e) {
        Log::critical($e->getMessage());
    }

    $translator = new Translator(new YandexTranslator());
    return $translator->translate($translated);
}

Answer 1

如果您想要更简洁的代码，只需为此工作制作一个 class。这两个API的两个class和controller中的两个classes进行单词的检查，如果数据库中不存在，则检查另外两个API的，只是拆分您将在新的两个 class 中执行的每个操作方法。

一种更简洁的方式来使用我的控制器方法

A cleaner way to go with my controller method

php

coding-style

code-cleanup

laravel-5