尝试混合来自 CSV 和哈希表的数据来创建变量

Question

我在 Code Review 停留，询问如何简化脚本，并被建议使用 哈希表，因为它会清理代码。我得到了一个非常基本的示例，但它不是 即插即用 。我已经编写了一些基本代码，但它没有按照我认为应该的方式运行。知道 Code Review 人员不会提供这样的支持，我在这里寻求有关将 CSV 和哈希表中的变量组合起来的帮助。我将留下我的 CSV 示例数据和下面的 Powershell 代码。

CSV 样本：

Student First Name,I,Student Last Name,Other ID,Stu Access Login,Student's School Email,School,Grad Year
Johosofat,L,Smith,999999,smithjoh000,smithjoh000@mydomain.org,30,2017
Tome,M,Smith,999998,smithtom000,smithtom000@mydomain.org,40,2021

Powershell 示例：

# Testing simple hash table
$SchoolCodes = @{
        20 = "Exeter Township Senior High"
        30 = "Exeter Township Junior High"
        40 = "Lorane Elementary School"
        50 = "Jacksonwald ES"
        70 = "Reiffton School"
        90 = "Owatin Creek Elementary School"
}

# CSV file being imported.
$CsvFile = "$env:USERPROFILE\Downloads\SampleData.csv"

# Import the contents of the CSV file.
$Users = Import-Csv -Path "$CsvFile"

# Loop through each line of the CSV, creating variables for each field.
ForEach ($User in $Users) {
    # Creating the basic variables.
    $FirstName = $User.'Student First Name'
    $MiddleInitial = $User.'I'
    $LastName = $User.'Student Last Name'
    $ADUserName = $User.'Stu Access Login'
    $StudentID = $User.'Other ID'
    $GradYear = $User.'Grad Year'
    $CapFInitial = $FirstName.substring(0,1).ToUpper()
    $MInitial = $MiddleInitial.substring(0,1).ToLower()
    $LInitial = $LastName.substring(0,1).ToLower()
    $Password = "$CapFInitial$MInitial$LInitial" + "#" + "$StudentID"
    $SchoolCode = $SchoolCodes[$User.School]


    If (-Not(Get-ADUser -Filter {SamAccountName -eq $ADUserName})) {
        Try {
            # Create user.
            New-ADUser `
                -Name "$FirstName $LastName" `
                -SamAccountName "$ADUserName" `
                -GivenName "$FirstName" `
                -Initials "$MiddleInitial" `
                -Surname "$LastName" `
                -DisplayName "$FirstName $MiddleInitial. $LastName" `
                -UserPrincipalName "$ADUserName@mydomain.k12.pa.us" `
                -EmailAddress "$ADUserName@mydomain.k12.pa.us" `
                -AccountPassword (ConvertTo-SecureString $Password -AsPlainText -Force) `
                -Enabled $false `
                -PasswordNeverExpires $true `
                -CannotChangePassword $true `
                -Path "OU=$GradYear,OU=Students,OU=$SchoolCode,OU=accounts,DC=academic,DC=mydomain,DC=k12,DC=pa,DC=us" `
                -WhatIf
        }

        Catch {
            Write-Error "[ERROR] Can't create user [$($ADUserName)] : $_"
        }
    }
}

我的问题： 我认为，由于 $SchoolCode 变量被设置为 null，脚本最终会出错。我希望脚本从 CSV 中的 school 字段中找到数字（代码），并将其与最终成为 AD 中的 OU 的名称相匹配——用户对象将在其中得到创造。基本上，代码尝试在 "CN=Tome Smith,OU=2021,OU=Students,OU=,OU=accounts,DC=academic,DC=exeter,DC=k12,DC=pa,DC=us" 中创建用户对象，这表明 $SchoolCode 变量为空或未正确设置。

正如我在评论中提到的，我们正在考虑将其他静态数据作为（嵌套的？）哈希表添加到哈希表中。这是我们正在考虑的一个例子。随着时间的推移，广告组列表可能会增长。

嵌套哈希表的示例：

$SchoolCodes = @{
    20 = @{
        Name = "Exeter Township Senior High"
        ADGroup1 = "Students"
        ADGroup2 = "Secondary Students"
    }
    30 = @{
        Name = "Exeter Township Junior High"
        ADGroup1 = "Students"
        ADGroup2 = "Secondary Students"
    }
    40 = @{
        Name = "Lorane Elementary School"
        ADGroup1 = "Students"
        ADGroup2 = "K4 Students"
    }
    50 = @{
        Name = "Jacksonwald ES"
        ADGroup1 = "Students"
        ADGroup2 = "K4 Students"
    }
    70 = @{
        Name = "Reiffton School"
        ADGroup1 = "Students"
        ADGroup2 = "Secondary Students"
    }
    90 = @{
        Name = "Owatin Creek Elementary School"
        ADGroup1 = "Students"
        ADGroup2 = "K4 Students"
    }
}

我正在网上搜索并试图更好地了解哈希表。如果我能全神贯注，下一步就是嵌套它们。

Answer 1

除非您要重新使用数据，否则将其转换为哈希表并不重要。此外，错误在于访问 $SchoolCodes 值。出于某种原因，访问器无法与 [String] 一起使用，但在您转换为 [Int]

时可以使用

示例数据集：

Student First Name,I,Student Last Name,Other ID,Stu Access Login,Student's School Email,School,Grad Year
Johosofat,L,Smith,999999,smithjoh000,smithjoh000@mydomain.org,30,2017
Tome,M,Smith,999998,smithtom000,smithtom000@mydomain.org,40,2021

代码：

#requires -Version 3
$SchoolCodes = @{
    20 = "Exeter Township Senior High"
    30 = "Exeter Township Junior High"
    40 = "Lorane Elementary School"
    50 = "Jacksonwald ES"
    70 = "Reiffton School"
    90 = "Owatin Creek Elementary School"
}

# CSV file being imported.
$CsvFile = "$env:USERPROFILE\Downloads\SampleData.csv"

# Import the contents of the CSV file.
$Users = Import-Csv -Path "$CsvFile"

# Loop through each line of the CSV, creating variables for each field.
ForEach ($User in $Users)
{
    [String]$LoginName = $User.'Stu Access Login'
    If (-not (Get-ADUser -Filter {SamAccountName -eq $LoginName}))
    {
        $FirstName = $User.'Student First Name'
        $LastName = $User.'Student Last Name'

        $Params = @{
            Name = "$FirstName $LastName"
            SamAccountName = $LoginName
            GivenName = $FirstName
            Initials = $User.I
            Surname = $LastName
            DisplayName = "$FirstName $($User.I) $LastName"
            UserPrincipalName = "$LoginName@mydomain.k12.pa.us"
            EmailAddress = "$LoginName@mydomain.k12.pa.us"
            AccountPassword = ConvertTo-SecureString -String (
                '{0}{1}{2}#{3}' -f @(
                    $FirstName[0].ToString().ToUpper(),
                    $User.I[0].ToString().ToLower(),
                    $LastName[0].ToString().ToLower(),
                    $User.'Other ID')) -AsPlainText -Force
            Enabled = $False
            PasswordNeverExpires = $True
            CannotChangePassword = $True
            Path = 'OU={0},OU=Students,OU={1},OU=accounts,DC=academic,DC=mydomain,DC=k12,DC=pa,DC=us' -f @(
                $User.'Grad Year',
                $SchoolCodes[[Int]$User.School])
            WhatIf = $True
        }

        Try {New-ADUser @Params}
        Catch {Write-Error "[ERROR] Can't create user [$LoginName] : $_"}
    }
}

尝试混合来自 CSV 和哈希表的数据来创建变量

Trying to mix data from a CSV and a hashtable to make a variable

csv

variables

powershell

hashtable

powershell-5.0