无论如何我可以将这段代码优化得更短吗？

Question

有没有办法优化这段代码，使其更短？ MakeList、TrimList 等都是List 类型。和 Vehicle 是模型。我的问题是代码很长。我有 20 属性个模型。

if (MakeList?.Any() == true)
{
    bidVehicles = bidVehicles.Where(b => MakeList.Contains(b.Vehicle.Make));
}
if (TrimList?.Any() == true)
{
    bidVehicles = bidVehicles.Where(b => TrimList.Contains(b.Vehicle.Trim));
}
if (ModelList?.Any() == true)
{
    bidVehicles = bidVehicles.Where(b => ModelList.Contains(b.Vehicle.Model));
}
if (StockNoList?.Any() == true)
{
    bidVehicles = bidVehicles.Where(b => StockNoList.Contains(b.Vehicle.StockNo));
}
if (BodyStyleList?.Any() == true)
{
    bidVehicles = bidVehicles.Where(b => BodyStyleList.Contains(b.Vehicle.Body));
}
if (ExtColorList?.Any() == true)
{
    bidVehicles = bidVehicles.Where(b => ExtColorList.Contains(b.Vehicle.Exterior));
}

return bidVehicles;

Answer 1

对于 LINQ to Objects：

public static class FilterExt
{
    public static IEnumerable<TItem> ApplyFilter<TProp, TItem>(this IEnumerable<TItem> list, List<TProp> filter, Func<TItem, TProp> prop)
    {
        if (filter == null || filter.Count == 0)
        {
            return list;
        }

        return list.Where(x => filter.Contains(prop.Invoke(x)));
    }
}

...

var filtered = bidVehicles
    .ApplyFilter(MakeList, x => x.Vehicle.Make)
    .ApplyFilter(TrimList, x => x.Vehicle.Trim).ToList();

如果您使用 EF（意味着 bidVehicles 是 IQueryable），您必须为每个属性编写表达式，因为您需要完整的谓词 Expression<Func<BidVehicle, bool>> 而不仅仅是 Func<BidVehicle, TProp>.

无论如何我可以将这段代码优化得更短吗？

Is there anyway I can optimize this code to much shorter?

c#

entity-framework

contains

filter