TSQL 改进查询
TSQL Improving queries
继承了两个查询 运行。 table 中大约有 5000 万行并且没有索引。后者将得到纠正，毫无疑问会提高性能，但是有什么关于提高这些效率的快速建议吗？
Update OP_working
Set Is_fertility =
(case
when PRIMARY_DIAGNOSIS_CODE_CLND in (select ICD10 from dbo.CH_ref_fertility_ICD10)
or SECONDARY_DIAGNOSIS_CODE_1_CLND IN (select ICD10 from dbo.CH_ref_fertility_ICD10)
or SECONDARY_DIAGNOSIS_CODE_2_CLND IN (select ICD10 from dbo.CH_ref_fertility_ICD10)
or SECONDARY_DIAGNOSIS_CODE_3_CLND IN (select ICD10 from dbo.CH_ref_fertility_ICD10)
or SECONDARY_DIAGNOSIS_CODE_4_CLND IN (select ICD10 from dbo.CH_ref_fertility_ICD10)
or SECONDARY_DIAGNOSIS_CODE_5_CLND IN (select ICD10 from dbo.CH_ref_fertility_ICD10)
or SECONDARY_DIAGNOSIS_CODE_6_CLND IN (select ICD10 from dbo.CH_ref_fertility_ICD10)
or SECONDARY_DIAGNOSIS_CODE_7_CLND IN (select ICD10 from dbo.CH_ref_fertility_ICD10)
or SECONDARY_DIAGNOSIS_CODE_8_CLND IN (select ICD10 from dbo.CH_ref_fertility_ICD10)
or SECONDARY_DIAGNOSIS_CODE_9_CLND IN (select ICD10 from dbo.CH_ref_fertility_ICD10)
or SECONDARY_DIAGNOSIS_CODE_10_CLND IN (select ICD10 from dbo.CH_ref_fertility_ICD10)
or SECONDARY_DIAGNOSIS_CODE_11_CLND IN (select ICD10 from dbo.CH_ref_fertility_ICD10)
or SECONDARY_DIAGNOSIS_CODE_12_CLND IN (select ICD10 from dbo.CH_ref_fertility_ICD10)
then '1'
when PRIMARY_PROCEDURE_CODE in (select OPCS from dbo.CH_ref_fertility_OPCS)
OR SECONDARY_PROCEDURE_CODE_1 IN (select OPCS from dbo.CH_ref_fertility_OPCS)
OR SECONDARY_PROCEDURE_CODE_2 IN (select OPCS from dbo.CH_ref_fertility_OPCS)
OR SECONDARY_PROCEDURE_CODE_3 IN (select OPCS from dbo.CH_ref_fertility_OPCS)
OR SECONDARY_PROCEDURE_CODE_4 IN (select OPCS from dbo.CH_ref_fertility_OPCS)
OR SECONDARY_PROCEDURE_CODE_5 IN (select OPCS from dbo.CH_ref_fertility_OPCS)
OR SECONDARY_PROCEDURE_CODE_6 IN (select OPCS from dbo.CH_ref_fertility_OPCS)
OR SECONDARY_PROCEDURE_CODE_7 IN (select OPCS from dbo.CH_ref_fertility_OPCS)
OR SECONDARY_PROCEDURE_CODE_8 IN (select OPCS from dbo.CH_ref_fertility_OPCS)
OR SECONDARY_PROCEDURE_CODE_9 IN (select OPCS from dbo.CH_ref_fertility_OPCS)
OR SECONDARY_PROCEDURE_CODE_10 IN (select OPCS from dbo.CH_ref_fertility_OPCS)
OR SECONDARY_PROCEDURE_CODE_11 IN (select OPCS from dbo.CH_ref_fertility_OPCS)
then '1'
else '0'
end
)
和
update OP_working
set derived_commissioner =
(case
when derived_commissioner_type = 'Private/Chargeable OSV' then 'VPP00'
when derived_commissioner_type = 'CCG_of_practise' and GP_PRACTICE_CODE not in(select GP_PRACTICE_CODE from dbo.CH_ref_practise_codes )then 'CCG_of_practise - unknown'
when derived_commissioner_type = 'CCG_of_practise' then (select [PARENT_CODE] from dbo.CH_ref_practise_codes where OP_working.GP_PRACTICE_CODE = CH_ref_practise_codes.GP_PRACTICE_CODE)--+' - '+derived_commissioner
when derived_commissioner_type = 'AT_of_Provider' and provider_code not in (select provider_code from CH_ref_provider_codes) then 'AT_of_Provider - Unknown'
when derived_commissioner_type = 'AT_of_Provider' then (select Commissioning_AT from dbo.CH_ref_provider_codes where OP_working.provider_code = CH_ref_provider_codes.ORG_CODE)--+' - '+derived_commissioner
when derived_commissioner_type = 'Commissioning_AT_of_prison' and GP_PRACTICE_CODE not in (select GP_PRACTICE_CODE from CH_ref_prison_practises) then 'Commissioning_AT_of_prison - Unknown'
when derived_commissioner_type = 'Commissioning_AT_of_prison' then (select [HUB_CODE] from dbo.CH_ref_prison_practises where OP_working.GP_PRACTICE_CODE = CH_ref_prison_practises.GP_PRACTICE_CODE)--+' - '+derived_commissioner
when derived_commissioner_type = 'Dental - AT_of_CCG' and GP_PRACTICE_CODE not in (select GP_PRACTICE_CODE from dbo.CH_ref_practise_codes) then 'AT_of_CCG - Unknown'
when derived_commissioner_type = 'Dental - AT_of_CCG' then (select [AREA_TEAM_CODE] from dbo.CH_ref_practise_codes where OP_working.GP_PRACTICE_CODE = CH_ref_practise_codes.GP_PRACTICE_CODE)--+' - '+derived_commissioner
when derived_commissioner_type = 'AT_of_CCG' and GP_PRACTICE_CODE not in (select GP_PRACTICE_CODE from dbo.CH_ref_practise_codes) then 'AT_of_CCG - Unknown'
when derived_commissioner_type = 'AT_of_CCG' then (select [AREA_TEAM_CODE] from dbo.CH_ref_practise_codes where OP_working.GP_PRACTICE_CODE = CH_ref_practise_codes.GP_PRACTICE_CODE)--+' - '+derived_commissioner
when derived_commissioner_type = 'Wales' then (select [PARENT_CODE] from dbo.CH_ref_practise_codes where OP_working.GP_PRACTICE_CODE = CH_ref_practise_codes.GP_PRACTICE_CODE)--+' - '+derived_commissioner
else derived_commissioner_type
end)
我正在考虑加入，而不是所有 "select in"，但首先想听听一些意见。
SQL服务器版本也是2012
谢谢
试试这个：
UPDATE t1
SET Is_fertility = coalesce(t2.x, t3.x, 0)
FROM OP_working t1
OUTER APPLY
(SELECT top 1 1 x
FROM dbo.CH_ref_fertility_ICD10
WHERE ICD10 IN
(t1.PRIMARY_DIAGNOSIS_CODE_CLND, t1.SECONDARY_DIAGNOSIS_CODE_1_CLND,
t1.SECONDARY_DIAGNOSIS_CODE_2_CLND, t1.SECONDARY_DIAGNOSIS_CODE_3_CLND,
t1.SECONDARY_DIAGNOSIS_CODE_4_CLND, t1.SECONDARY_DIAGNOSIS_CODE_5_CLND,
t1.SECONDARY_DIAGNOSIS_CODE_6_CLND, t1.SECONDARY_DIAGNOSIS_CODE_7_CLND,
t1.SECONDARY_DIAGNOSIS_CODE_8_CLND, t1.SECONDARY_DIAGNOSIS_CODE_9_CLND,
t1.SECONDARY_DIAGNOSIS_CODE_10_CLND, t1.SECONDARY_DIAGNOSIS_CODE_11_CLND,
t1.SECONDARY_DIAGNOSIS_CODE_12_CLND)
ORDER BY (SELECT 1)
) t2
OUTER APPLY
(SELECT top 1 1 x
FROM dbo.CH_ref_fertility_OPCS
WHERE OPCS IN
(t1.PRIMARY_PROCEDURE_CODE, t1.SECONDARY_PROCEDURE_CODE_1,
t1.SECONDARY_PROCEDURE_CODE_2, t1.SECONDARY_PROCEDURE_CODE_3,
t1.SECONDARY_PROCEDURE_CODE_4, t1.SECONDARY_PROCEDURE_CODE_5,
t1.SECONDARY_PROCEDURE_CODE_6, t1.SECONDARY_PROCEDURE_CODE_7,
t1.SECONDARY_PROCEDURE_CODE_8, t1.SECONDARY_PROCEDURE_CODE_9,
t1.SECONDARY_PROCEDURE_CODE_10, t1.SECONDARY_PROCEDURE_CODE_11)
ORDER BY (SELECT 1)
) t3
不确定这是否适用于 5000 万行，但我认为它比您当前的脚本更快。抱歉，不打算尝试第 2 部分
除非您自己测试，否则没有人能告诉您最好的方法。我会使用这样的临时表来做到这一点：
DECLARE @ICD10 TABLE ( ID INT )
DECLARE @OPCS TABLE ( ID INT )
INSERT INTO @ICD10
SELECT ICD10
FROM dbo.CH_ref_fertility_ICD10
INSERT INTO @OPCS
SELECT OPCS
FROM dbo.CH_ref_fertility_OPCS
UPDATE OP_working
SET Is_fertility = 0
UPDATE w
SET Is_fertility = 1
FROM OP_working w
JOIN @ICD10 t ON t.ID = PRIMARY_DIAGNOSIS_CODE_CLND
OR t.ID = SECONDARY_DIAGNOSIS_CODE_1_CLND
OR t.ID = SECONDARY_DIAGNOSIS_CODE_2_CLND
OR t.ID = SECONDARY_DIAGNOSIS_CODE_3_CLND
OR t.ID = SECONDARY_DIAGNOSIS_CODE_4_CLND
OR t.ID = SECONDARY_DIAGNOSIS_CODE_5_CLND
OR t.ID = SECONDARY_DIAGNOSIS_CODE_6_CLND
OR t.ID = SECONDARY_DIAGNOSIS_CODE_7_CLND
OR t.ID = SECONDARY_DIAGNOSIS_CODE_8_CLND
OR t.ID = SECONDARY_DIAGNOSIS_CODE_9_CLND
OR t.ID = SECONDARY_DIAGNOSIS_CODE_10_CLND
OR t.ID = SECONDARY_DIAGNOSIS_CODE_11_CLND
OR t.ID = SECONDARY_DIAGNOSIS_CODE_12_CLND
UPDATE w
SET Is_fertility = 1
FROM OP_working w
JOIN @OPCS t ON t.ID = PRIMARY_PROCEDURE_CODE
OR t.ID = SECONDARY_PROCEDURE_CODE_1
OR t.ID = SECONDARY_PROCEDURE_CODE_2
OR t.ID = SECONDARY_PROCEDURE_CODE_3
OR t.ID = SECONDARY_PROCEDURE_CODE_4
OR t.ID = SECONDARY_PROCEDURE_CODE_5
OR t.ID = SECONDARY_PROCEDURE_CODE_6
OR t.ID = SECONDARY_PROCEDURE_CODE_7
OR t.ID = SECONDARY_PROCEDURE_CODE_8
OR t.ID = SECONDARY_PROCEDURE_CODE_9
OR t.ID = SECONDARY_PROCEDURE_CODE_10
OR t.ID = SECONDARY_PROCEDURE_CODE_11
第二个语句呢，尝试优化它太复杂了。尝试将案例分成不同的更新语句。
继承了两个查询 运行。 table 中大约有 5000 万行并且没有索引。后者将得到纠正，毫无疑问会提高性能，但是有什么关于提高这些效率的快速建议吗？
Update OP_working
Set Is_fertility =
(case
when PRIMARY_DIAGNOSIS_CODE_CLND in (select ICD10 from dbo.CH_ref_fertility_ICD10)
or SECONDARY_DIAGNOSIS_CODE_1_CLND IN (select ICD10 from dbo.CH_ref_fertility_ICD10)
or SECONDARY_DIAGNOSIS_CODE_2_CLND IN (select ICD10 from dbo.CH_ref_fertility_ICD10)
or SECONDARY_DIAGNOSIS_CODE_3_CLND IN (select ICD10 from dbo.CH_ref_fertility_ICD10)
or SECONDARY_DIAGNOSIS_CODE_4_CLND IN (select ICD10 from dbo.CH_ref_fertility_ICD10)
or SECONDARY_DIAGNOSIS_CODE_5_CLND IN (select ICD10 from dbo.CH_ref_fertility_ICD10)
or SECONDARY_DIAGNOSIS_CODE_6_CLND IN (select ICD10 from dbo.CH_ref_fertility_ICD10)
or SECONDARY_DIAGNOSIS_CODE_7_CLND IN (select ICD10 from dbo.CH_ref_fertility_ICD10)
or SECONDARY_DIAGNOSIS_CODE_8_CLND IN (select ICD10 from dbo.CH_ref_fertility_ICD10)
or SECONDARY_DIAGNOSIS_CODE_9_CLND IN (select ICD10 from dbo.CH_ref_fertility_ICD10)
or SECONDARY_DIAGNOSIS_CODE_10_CLND IN (select ICD10 from dbo.CH_ref_fertility_ICD10)
or SECONDARY_DIAGNOSIS_CODE_11_CLND IN (select ICD10 from dbo.CH_ref_fertility_ICD10)
or SECONDARY_DIAGNOSIS_CODE_12_CLND IN (select ICD10 from dbo.CH_ref_fertility_ICD10)
then '1'
when PRIMARY_PROCEDURE_CODE in (select OPCS from dbo.CH_ref_fertility_OPCS)
OR SECONDARY_PROCEDURE_CODE_1 IN (select OPCS from dbo.CH_ref_fertility_OPCS)
OR SECONDARY_PROCEDURE_CODE_2 IN (select OPCS from dbo.CH_ref_fertility_OPCS)
OR SECONDARY_PROCEDURE_CODE_3 IN (select OPCS from dbo.CH_ref_fertility_OPCS)
OR SECONDARY_PROCEDURE_CODE_4 IN (select OPCS from dbo.CH_ref_fertility_OPCS)
OR SECONDARY_PROCEDURE_CODE_5 IN (select OPCS from dbo.CH_ref_fertility_OPCS)
OR SECONDARY_PROCEDURE_CODE_6 IN (select OPCS from dbo.CH_ref_fertility_OPCS)
OR SECONDARY_PROCEDURE_CODE_7 IN (select OPCS from dbo.CH_ref_fertility_OPCS)
OR SECONDARY_PROCEDURE_CODE_8 IN (select OPCS from dbo.CH_ref_fertility_OPCS)
OR SECONDARY_PROCEDURE_CODE_9 IN (select OPCS from dbo.CH_ref_fertility_OPCS)
OR SECONDARY_PROCEDURE_CODE_10 IN (select OPCS from dbo.CH_ref_fertility_OPCS)
OR SECONDARY_PROCEDURE_CODE_11 IN (select OPCS from dbo.CH_ref_fertility_OPCS)
then '1'
else '0'
end
)
和
update OP_working
set derived_commissioner =
(case
when derived_commissioner_type = 'Private/Chargeable OSV' then 'VPP00'
when derived_commissioner_type = 'CCG_of_practise' and GP_PRACTICE_CODE not in(select GP_PRACTICE_CODE from dbo.CH_ref_practise_codes )then 'CCG_of_practise - unknown'
when derived_commissioner_type = 'CCG_of_practise' then (select [PARENT_CODE] from dbo.CH_ref_practise_codes where OP_working.GP_PRACTICE_CODE = CH_ref_practise_codes.GP_PRACTICE_CODE)--+' - '+derived_commissioner
when derived_commissioner_type = 'AT_of_Provider' and provider_code not in (select provider_code from CH_ref_provider_codes) then 'AT_of_Provider - Unknown'
when derived_commissioner_type = 'AT_of_Provider' then (select Commissioning_AT from dbo.CH_ref_provider_codes where OP_working.provider_code = CH_ref_provider_codes.ORG_CODE)--+' - '+derived_commissioner
when derived_commissioner_type = 'Commissioning_AT_of_prison' and GP_PRACTICE_CODE not in (select GP_PRACTICE_CODE from CH_ref_prison_practises) then 'Commissioning_AT_of_prison - Unknown'
when derived_commissioner_type = 'Commissioning_AT_of_prison' then (select [HUB_CODE] from dbo.CH_ref_prison_practises where OP_working.GP_PRACTICE_CODE = CH_ref_prison_practises.GP_PRACTICE_CODE)--+' - '+derived_commissioner
when derived_commissioner_type = 'Dental - AT_of_CCG' and GP_PRACTICE_CODE not in (select GP_PRACTICE_CODE from dbo.CH_ref_practise_codes) then 'AT_of_CCG - Unknown'
when derived_commissioner_type = 'Dental - AT_of_CCG' then (select [AREA_TEAM_CODE] from dbo.CH_ref_practise_codes where OP_working.GP_PRACTICE_CODE = CH_ref_practise_codes.GP_PRACTICE_CODE)--+' - '+derived_commissioner
when derived_commissioner_type = 'AT_of_CCG' and GP_PRACTICE_CODE not in (select GP_PRACTICE_CODE from dbo.CH_ref_practise_codes) then 'AT_of_CCG - Unknown'
when derived_commissioner_type = 'AT_of_CCG' then (select [AREA_TEAM_CODE] from dbo.CH_ref_practise_codes where OP_working.GP_PRACTICE_CODE = CH_ref_practise_codes.GP_PRACTICE_CODE)--+' - '+derived_commissioner
when derived_commissioner_type = 'Wales' then (select [PARENT_CODE] from dbo.CH_ref_practise_codes where OP_working.GP_PRACTICE_CODE = CH_ref_practise_codes.GP_PRACTICE_CODE)--+' - '+derived_commissioner
else derived_commissioner_type
end)
我正在考虑加入，而不是所有 "select in"，但首先想听听一些意见。
SQL服务器版本也是2012
谢谢
试试这个：
UPDATE t1
SET Is_fertility = coalesce(t2.x, t3.x, 0)
FROM OP_working t1
OUTER APPLY
(SELECT top 1 1 x
FROM dbo.CH_ref_fertility_ICD10
WHERE ICD10 IN
(t1.PRIMARY_DIAGNOSIS_CODE_CLND, t1.SECONDARY_DIAGNOSIS_CODE_1_CLND,
t1.SECONDARY_DIAGNOSIS_CODE_2_CLND, t1.SECONDARY_DIAGNOSIS_CODE_3_CLND,
t1.SECONDARY_DIAGNOSIS_CODE_4_CLND, t1.SECONDARY_DIAGNOSIS_CODE_5_CLND,
t1.SECONDARY_DIAGNOSIS_CODE_6_CLND, t1.SECONDARY_DIAGNOSIS_CODE_7_CLND,
t1.SECONDARY_DIAGNOSIS_CODE_8_CLND, t1.SECONDARY_DIAGNOSIS_CODE_9_CLND,
t1.SECONDARY_DIAGNOSIS_CODE_10_CLND, t1.SECONDARY_DIAGNOSIS_CODE_11_CLND,
t1.SECONDARY_DIAGNOSIS_CODE_12_CLND)
ORDER BY (SELECT 1)
) t2
OUTER APPLY
(SELECT top 1 1 x
FROM dbo.CH_ref_fertility_OPCS
WHERE OPCS IN
(t1.PRIMARY_PROCEDURE_CODE, t1.SECONDARY_PROCEDURE_CODE_1,
t1.SECONDARY_PROCEDURE_CODE_2, t1.SECONDARY_PROCEDURE_CODE_3,
t1.SECONDARY_PROCEDURE_CODE_4, t1.SECONDARY_PROCEDURE_CODE_5,
t1.SECONDARY_PROCEDURE_CODE_6, t1.SECONDARY_PROCEDURE_CODE_7,
t1.SECONDARY_PROCEDURE_CODE_8, t1.SECONDARY_PROCEDURE_CODE_9,
t1.SECONDARY_PROCEDURE_CODE_10, t1.SECONDARY_PROCEDURE_CODE_11)
ORDER BY (SELECT 1)
) t3
不确定这是否适用于 5000 万行，但我认为它比您当前的脚本更快。抱歉，不打算尝试第 2 部分
除非您自己测试，否则没有人能告诉您最好的方法。我会使用这样的临时表来做到这一点：
DECLARE @ICD10 TABLE ( ID INT )
DECLARE @OPCS TABLE ( ID INT )
INSERT INTO @ICD10
SELECT ICD10
FROM dbo.CH_ref_fertility_ICD10
INSERT INTO @OPCS
SELECT OPCS
FROM dbo.CH_ref_fertility_OPCS
UPDATE OP_working
SET Is_fertility = 0
UPDATE w
SET Is_fertility = 1
FROM OP_working w
JOIN @ICD10 t ON t.ID = PRIMARY_DIAGNOSIS_CODE_CLND
OR t.ID = SECONDARY_DIAGNOSIS_CODE_1_CLND
OR t.ID = SECONDARY_DIAGNOSIS_CODE_2_CLND
OR t.ID = SECONDARY_DIAGNOSIS_CODE_3_CLND
OR t.ID = SECONDARY_DIAGNOSIS_CODE_4_CLND
OR t.ID = SECONDARY_DIAGNOSIS_CODE_5_CLND
OR t.ID = SECONDARY_DIAGNOSIS_CODE_6_CLND
OR t.ID = SECONDARY_DIAGNOSIS_CODE_7_CLND
OR t.ID = SECONDARY_DIAGNOSIS_CODE_8_CLND
OR t.ID = SECONDARY_DIAGNOSIS_CODE_9_CLND
OR t.ID = SECONDARY_DIAGNOSIS_CODE_10_CLND
OR t.ID = SECONDARY_DIAGNOSIS_CODE_11_CLND
OR t.ID = SECONDARY_DIAGNOSIS_CODE_12_CLND
UPDATE w
SET Is_fertility = 1
FROM OP_working w
JOIN @OPCS t ON t.ID = PRIMARY_PROCEDURE_CODE
OR t.ID = SECONDARY_PROCEDURE_CODE_1
OR t.ID = SECONDARY_PROCEDURE_CODE_2
OR t.ID = SECONDARY_PROCEDURE_CODE_3
OR t.ID = SECONDARY_PROCEDURE_CODE_4
OR t.ID = SECONDARY_PROCEDURE_CODE_5
OR t.ID = SECONDARY_PROCEDURE_CODE_6
OR t.ID = SECONDARY_PROCEDURE_CODE_7
OR t.ID = SECONDARY_PROCEDURE_CODE_8
OR t.ID = SECONDARY_PROCEDURE_CODE_9
OR t.ID = SECONDARY_PROCEDURE_CODE_10
OR t.ID = SECONDARY_PROCEDURE_CODE_11
第二个语句呢，尝试优化它太复杂了。尝试将案例分成不同的更新语句。