[]运算符访问unordered_map时出错
Errors occurs when accessing unordered_map by [] operator
我偶然发现了一个 unordered_map.
的奇怪问题
首先我生成了一个 unordered_map<string, Person>
并在 table 中插入了一条记录 ("Bob", Person(1, "Bob"))。然后我尝试使用带有键 "Bob" 的 [] 运算符来访问记录,但发生了错误。
这是代码:
#include<iostream>
#include<unordered_map>
using namespace std;
class Person
{
public:
int play;
string name;
Person(int p, string n):play(p), name(n) {}
};
int main()
{
unordered_map<string,Person> test;
test.insert(std::make_pair("haha",Person(1,"haha")));
cout<<test["haha"].name<<endl;
return 0;
}
使用"g++ -S hash.cpp"编译代码时出现错误
输出:
In file included from /usr/include/c++/7/unordered_map:41:0,
from hash.cpp:2:
/usr/include/c++/7/tuple: In instantiation of ‘std::pair<_T1, _T2>::pair(std::tuple<_Args1 ...>&, std::tuple<_Args2 ...>&, std::_Index_tuple<_Indexes1 ...>, std::_Index_tuple<_Indexes2 ...>) [with _Args1 = {std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&}; long unsigned int ..._Indexes1 = {0}; _Args2 = {}; long unsigned int ..._Indexes2 = {}; _T1 = const std::__cxx11::basic_string<char>; _T2 = Person]’:
/usr/include/c++/7/tuple:1641:63: required from ‘std::pair<_T1, _T2>::pair(std::piecewise_construct_t, std::tuple<_Args1 ...>, std::tuple<_Args2 ...>) [with _Args1 = {std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&}; _Args2 = {}; _T1 = const std::__cxx11::basic_string<char>; _T2 = Person]’
/usr/include/c++/7/ext/new_allocator.h:136:4: required from ‘void __gnu_cxx::new_allocator<_Tp>::construct(_Up*, _Args&& ...) [with _Up = std::pair<const std::__cxx11::basic_string<char>, Person>; _Args = {const std::piecewise_construct_t&, std::tuple<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&>, std::tuple<>}; _Tp = std::pair<const std::__cxx11::basic_string<char>, Person>]’
/usr/include/c++/7/bits/alloc_traits.h:475:4: required from ‘static void std::allocator_traits<std::allocator<_CharT> >::construct(std::allocator_traits<std::allocator<_CharT> >::allocator_type&, _Up*, _Args&& ...) [with _Up = std::pair<const std::__cxx11::basic_string<char>, Person>; _Args = {const std::piecewise_construct_t&, std::tuple<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&>, std::tuple<>}; _Tp = std::pair<const std::__cxx11::basic_string<char>, Person>; std::allocator_traits<std::allocator<_CharT> >::allocator_type = std::allocator<std::pair<const std::__cxx11::basic_string<char>, Person> >]’
/usr/include/c++/7/bits/hashtable_policy.h:2066:37: required from ‘std::__detail::_Hashtable_alloc<_NodeAlloc>::__node_type* std::__detail::_Hashtable_alloc<_NodeAlloc>::_M_allocate_node(_Args&& ...) [with _Args = {const std::piecewise_construct_t&, std::tuple<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&>, std::tuple<>}; _NodeAlloc = std::allocator<std::__detail::_Hash_node<std::pair<const std::__cxx11::basic_string<char>, Person>, true> >; std::__detail::_Hashtable_alloc<_NodeAlloc>::__node_type = std::__detail::_Hash_node<std::pair<const std::__cxx11::basic_string<char>, Person>, true>]’
/usr/include/c++/7/bits/hashtable_policy.h:750:8: required from ‘std::__detail::_Map_base<_Key, _Pair, _Alloc, std::__detail::_Select1st, _Equal, _H1, _H2, _Hash, _RehashPolicy, _Traits, true>::mapped_type& std::__detail::_Map_base<_Key, _Pair, _Alloc, std::__detail::_Select1st, _Equal, _H1, _H2, _Hash, _RehashPolicy, _Traits, true>::operator[](std::__detail::_Map_base<_Key, _Pair, _Alloc, std::__detail::_Select1st, _Equal, _H1, _H2, _Hash, _RehashPolicy, _Traits, true>::key_type&&) [with _Key = std::__cxx11::basic_string<char>; _Pair = std::pair<const std::__cxx11::basic_string<char>, Person>; _Alloc = std::allocator<std::pair<const std::__cxx11::basic_string<char>, Person> >; _Equal = std::equal_to<std::__cxx11::basic_string<char> >; _H1 = std::hash<std::__cxx11::basic_string<char> >; _H2 = std::__detail::_Mod_range_hashing; _Hash = std::__detail::_Default_ranged_hash; _RehashPolicy = std::__detail::_Prime_rehash_policy; _Traits = std::__detail::_Hashtable_traits<true, false, true>; std::__detail::_Map_base<_Key, _Pair, _Alloc, std::__detail::_Select1st, _Equal, _H1, _H2, _Hash, _RehashPolicy, _Traits, true>::mapped_type = Person; std::__detail::_Map_base<_Key, _Pair, _Alloc, std::__detail::_Select1st, _Equal, _H1, _H2, _Hash, _RehashPolicy, _Traits, true>::key_type = std::__cxx11::basic_string<char>]’
/usr/include/c++/7/bits/unordered_map.h:980:20: required from ‘std::unordered_map<_Key, _Tp, _Hash, _Pred, _Alloc>::mapped_type& std::unordered_map<_Key, _Tp, _Hash, _Pred, _Alloc>::operator[](std::unordered_map<_Key, _Tp, _Hash, _Pred, _Alloc>::key_type&&) [with _Key = std::__cxx11::basic_string<char>; _Tp = Person; _Hash = std::hash<std::__cxx11::basic_string<char> >; _Pred = std::equal_to<std::__cxx11::basic_string<char> >; _Alloc = std::allocator<std::pair<const std::__cxx11::basic_string<char>, Person> >; std::unordered_map<_Key, _Tp, _Hash, _Pred, _Alloc>::mapped_type = Person; std::unordered_map<_Key, _Tp, _Hash, _Pred, _Alloc>::key_type = std::__cxx11::basic_string<char>]’
hash.cpp:17:19: required from here
/usr/include/c++/7/tuple:1652:70: error: no matching function for call to ‘Person::Person()’
second(std::forward<_Args2>(std::get<_Indexes2>(__tuple2))...)
^
hash.cpp:10:3: note: candidate: Person::Person(int, std::__cxx11::string)
Person(int p, string n):play(p), name(n) {}
^~~~~~
hash.cpp:10:3: note: candidate expects 2 arguments, 0 provided
hash.cpp:5:7: note: candidate: Person::Person(const Person&)
class Person
^~~~~~
hash.cpp:5:7: note: candidate expects 1 argument, 0 provided
hash.cpp:5:7: note: candidate: Person::Person(Person&&)
hash.cpp:5:7: note: candidate expects 1 argument, 0 provided
我已经插入了记录,但是地图似乎没有意识到这一点,并试图再次插入记录。
那么g++编译器是如何处理[]运算符的呢?
谢谢。
问题不在于 [] 运算符。实际问题是当编译器执行以下行时:
cout<<test["haha"].name<<endl;
它尝试使用它的默认构造函数创建一个类型为 Person 的对象。由于未定义默认构造函数,因此会引发错误。
以下代码可以正常工作。我刚刚添加了一个默认构造函数。
#include<iostream>
#include<unordered_map>
using namespace std;
class Person
{
public:
int play;
string name;
Person(){} //Add default constructor
Person(int p, string n):play(p), name(n) {}
};
int main()
{
unordered_map<string,Person> test;
test.insert(std::make_pair("haha",Person(1,"haha")));
cout<<test["haha"].name<<endl;
return 0;
}
unordered_map 的映射类型必须是 operator[]
下的 DefaultConstructible。 IE。 Person() 必须有一个默认构造函数,如果你想能够使用 operator[]
.
作为替代方法,使用 at():
int main()
{
std::unordered_map<string,Person> test;
test.insert(std::make_pair("haha",Person(1,"haha")));
std::cout<<test.at("haha").name<<'\n';
return 0;
}
映射类型必须是 DefaultConstructible,因为 operator[]
应该能够创建缺失的条目。新条目中的数据是默认构造的。
如评论和另一个答案中所述,unordered_map<>::operator[]
可能 需要创建一个对象:如果为键找到 none,它会插入默认构造的元素和 returns that.
如果这不是您想要的,您可以简单地尝试找到一个元素,并且只在存在时使用它:
auto it = map.find("haha");
if(it != map.end()) {
cout << it->second.name;
}
顺便说一句,在内部 unordered_map
保持为 value_type
和 std::pair<key,Person>
。因此,如果您按名称散列(就像您所做的那样),Person
的名称将存储两次。避免这种情况的一种可能方法是以下结构:
struct personData
{
int play; // etc
};
using personMap = unordered_map<string,personData>;
using person = personMap::value_type;
唯一的不便是您必须通过person::second.play
访问play
这样的数据。解决这个问题的一种方法是定义
struct person : private personMap::value_type
{
using base = personMap::value_type;
// must not add new data members to avoid slicing
personData& data() { return base.second; }
personData const& data() const { return base.second; }
int play() const { return data().play; }
string const&name() const { return base.first; }
};
auto fred = static_cast<person&>(map["fred"]);
给出的答案是正确的。我只想补充为什么在这种情况下编译器不提供默认构造函数:
来自网络cpp reference
If no user-declared constructors of any kind are provided for a class type (struct, class, or union), the compiler will always declare a default constructor as an inline public member of its class.
但是如果提供了用户声明的任何类型的构造函数,编译器将不会生成默认构造函数。
If some user-declared constructors are present, the user may still force the automatic generation of a default constructor by the compiler that would be implicitly-declared otherwise with the keyword default. (since C++11)
因此,您可以将以下行添加到 class 的 public 部分的代码中,您的代码将按预期运行:
Person() = default;
我偶然发现了一个 unordered_map.
的奇怪问题首先我生成了一个 unordered_map<string, Person>
并在 table 中插入了一条记录 ("Bob", Person(1, "Bob"))。然后我尝试使用带有键 "Bob" 的 [] 运算符来访问记录,但发生了错误。
这是代码:
#include<iostream>
#include<unordered_map>
using namespace std;
class Person
{
public:
int play;
string name;
Person(int p, string n):play(p), name(n) {}
};
int main()
{
unordered_map<string,Person> test;
test.insert(std::make_pair("haha",Person(1,"haha")));
cout<<test["haha"].name<<endl;
return 0;
}
使用"g++ -S hash.cpp"编译代码时出现错误 输出:
In file included from /usr/include/c++/7/unordered_map:41:0,
from hash.cpp:2:
/usr/include/c++/7/tuple: In instantiation of ‘std::pair<_T1, _T2>::pair(std::tuple<_Args1 ...>&, std::tuple<_Args2 ...>&, std::_Index_tuple<_Indexes1 ...>, std::_Index_tuple<_Indexes2 ...>) [with _Args1 = {std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&}; long unsigned int ..._Indexes1 = {0}; _Args2 = {}; long unsigned int ..._Indexes2 = {}; _T1 = const std::__cxx11::basic_string<char>; _T2 = Person]’:
/usr/include/c++/7/tuple:1641:63: required from ‘std::pair<_T1, _T2>::pair(std::piecewise_construct_t, std::tuple<_Args1 ...>, std::tuple<_Args2 ...>) [with _Args1 = {std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&}; _Args2 = {}; _T1 = const std::__cxx11::basic_string<char>; _T2 = Person]’
/usr/include/c++/7/ext/new_allocator.h:136:4: required from ‘void __gnu_cxx::new_allocator<_Tp>::construct(_Up*, _Args&& ...) [with _Up = std::pair<const std::__cxx11::basic_string<char>, Person>; _Args = {const std::piecewise_construct_t&, std::tuple<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&>, std::tuple<>}; _Tp = std::pair<const std::__cxx11::basic_string<char>, Person>]’
/usr/include/c++/7/bits/alloc_traits.h:475:4: required from ‘static void std::allocator_traits<std::allocator<_CharT> >::construct(std::allocator_traits<std::allocator<_CharT> >::allocator_type&, _Up*, _Args&& ...) [with _Up = std::pair<const std::__cxx11::basic_string<char>, Person>; _Args = {const std::piecewise_construct_t&, std::tuple<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&>, std::tuple<>}; _Tp = std::pair<const std::__cxx11::basic_string<char>, Person>; std::allocator_traits<std::allocator<_CharT> >::allocator_type = std::allocator<std::pair<const std::__cxx11::basic_string<char>, Person> >]’
/usr/include/c++/7/bits/hashtable_policy.h:2066:37: required from ‘std::__detail::_Hashtable_alloc<_NodeAlloc>::__node_type* std::__detail::_Hashtable_alloc<_NodeAlloc>::_M_allocate_node(_Args&& ...) [with _Args = {const std::piecewise_construct_t&, std::tuple<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&>, std::tuple<>}; _NodeAlloc = std::allocator<std::__detail::_Hash_node<std::pair<const std::__cxx11::basic_string<char>, Person>, true> >; std::__detail::_Hashtable_alloc<_NodeAlloc>::__node_type = std::__detail::_Hash_node<std::pair<const std::__cxx11::basic_string<char>, Person>, true>]’
/usr/include/c++/7/bits/hashtable_policy.h:750:8: required from ‘std::__detail::_Map_base<_Key, _Pair, _Alloc, std::__detail::_Select1st, _Equal, _H1, _H2, _Hash, _RehashPolicy, _Traits, true>::mapped_type& std::__detail::_Map_base<_Key, _Pair, _Alloc, std::__detail::_Select1st, _Equal, _H1, _H2, _Hash, _RehashPolicy, _Traits, true>::operator[](std::__detail::_Map_base<_Key, _Pair, _Alloc, std::__detail::_Select1st, _Equal, _H1, _H2, _Hash, _RehashPolicy, _Traits, true>::key_type&&) [with _Key = std::__cxx11::basic_string<char>; _Pair = std::pair<const std::__cxx11::basic_string<char>, Person>; _Alloc = std::allocator<std::pair<const std::__cxx11::basic_string<char>, Person> >; _Equal = std::equal_to<std::__cxx11::basic_string<char> >; _H1 = std::hash<std::__cxx11::basic_string<char> >; _H2 = std::__detail::_Mod_range_hashing; _Hash = std::__detail::_Default_ranged_hash; _RehashPolicy = std::__detail::_Prime_rehash_policy; _Traits = std::__detail::_Hashtable_traits<true, false, true>; std::__detail::_Map_base<_Key, _Pair, _Alloc, std::__detail::_Select1st, _Equal, _H1, _H2, _Hash, _RehashPolicy, _Traits, true>::mapped_type = Person; std::__detail::_Map_base<_Key, _Pair, _Alloc, std::__detail::_Select1st, _Equal, _H1, _H2, _Hash, _RehashPolicy, _Traits, true>::key_type = std::__cxx11::basic_string<char>]’
/usr/include/c++/7/bits/unordered_map.h:980:20: required from ‘std::unordered_map<_Key, _Tp, _Hash, _Pred, _Alloc>::mapped_type& std::unordered_map<_Key, _Tp, _Hash, _Pred, _Alloc>::operator[](std::unordered_map<_Key, _Tp, _Hash, _Pred, _Alloc>::key_type&&) [with _Key = std::__cxx11::basic_string<char>; _Tp = Person; _Hash = std::hash<std::__cxx11::basic_string<char> >; _Pred = std::equal_to<std::__cxx11::basic_string<char> >; _Alloc = std::allocator<std::pair<const std::__cxx11::basic_string<char>, Person> >; std::unordered_map<_Key, _Tp, _Hash, _Pred, _Alloc>::mapped_type = Person; std::unordered_map<_Key, _Tp, _Hash, _Pred, _Alloc>::key_type = std::__cxx11::basic_string<char>]’
hash.cpp:17:19: required from here
/usr/include/c++/7/tuple:1652:70: error: no matching function for call to ‘Person::Person()’
second(std::forward<_Args2>(std::get<_Indexes2>(__tuple2))...)
^
hash.cpp:10:3: note: candidate: Person::Person(int, std::__cxx11::string)
Person(int p, string n):play(p), name(n) {}
^~~~~~
hash.cpp:10:3: note: candidate expects 2 arguments, 0 provided
hash.cpp:5:7: note: candidate: Person::Person(const Person&)
class Person
^~~~~~
hash.cpp:5:7: note: candidate expects 1 argument, 0 provided
hash.cpp:5:7: note: candidate: Person::Person(Person&&)
hash.cpp:5:7: note: candidate expects 1 argument, 0 provided
我已经插入了记录,但是地图似乎没有意识到这一点,并试图再次插入记录。
那么g++编译器是如何处理[]运算符的呢?
谢谢。
问题不在于 [] 运算符。实际问题是当编译器执行以下行时:
cout<<test["haha"].name<<endl;
它尝试使用它的默认构造函数创建一个类型为 Person 的对象。由于未定义默认构造函数,因此会引发错误。
以下代码可以正常工作。我刚刚添加了一个默认构造函数。
#include<iostream>
#include<unordered_map>
using namespace std;
class Person
{
public:
int play;
string name;
Person(){} //Add default constructor
Person(int p, string n):play(p), name(n) {}
};
int main()
{
unordered_map<string,Person> test;
test.insert(std::make_pair("haha",Person(1,"haha")));
cout<<test["haha"].name<<endl;
return 0;
}
unordered_map 的映射类型必须是 operator[]
下的 DefaultConstructible。 IE。 Person() 必须有一个默认构造函数,如果你想能够使用 operator[]
.
作为替代方法,使用 at():
int main()
{
std::unordered_map<string,Person> test;
test.insert(std::make_pair("haha",Person(1,"haha")));
std::cout<<test.at("haha").name<<'\n';
return 0;
}
映射类型必须是 DefaultConstructible,因为 operator[]
应该能够创建缺失的条目。新条目中的数据是默认构造的。
如评论和另一个答案中所述,unordered_map<>::operator[]
可能 需要创建一个对象:如果为键找到 none,它会插入默认构造的元素和 returns that.
如果这不是您想要的,您可以简单地尝试找到一个元素,并且只在存在时使用它:
auto it = map.find("haha");
if(it != map.end()) {
cout << it->second.name;
}
顺便说一句,在内部 unordered_map
保持为 value_type
和 std::pair<key,Person>
。因此,如果您按名称散列(就像您所做的那样),Person
的名称将存储两次。避免这种情况的一种可能方法是以下结构:
struct personData
{
int play; // etc
};
using personMap = unordered_map<string,personData>;
using person = personMap::value_type;
唯一的不便是您必须通过person::second.play
访问play
这样的数据。解决这个问题的一种方法是定义
struct person : private personMap::value_type
{
using base = personMap::value_type;
// must not add new data members to avoid slicing
personData& data() { return base.second; }
personData const& data() const { return base.second; }
int play() const { return data().play; }
string const&name() const { return base.first; }
};
auto fred = static_cast<person&>(map["fred"]);
给出的答案是正确的。我只想补充为什么在这种情况下编译器不提供默认构造函数:
来自网络cpp reference
If no user-declared constructors of any kind are provided for a class type (struct, class, or union), the compiler will always declare a default constructor as an inline public member of its class.
但是如果提供了用户声明的任何类型的构造函数,编译器将不会生成默认构造函数。
If some user-declared constructors are present, the user may still force the automatic generation of a default constructor by the compiler that would be implicitly-declared otherwise with the keyword default. (since C++11)
因此,您可以将以下行添加到 class 的 public 部分的代码中,您的代码将按预期运行:
Person() = default;