动态内存分配和堆损坏

Question

对于学校的作业，我需要创建一个程序，它接受一个数组并将另一个数组拼接到其中，将第一个数组的第一个 X 值分配给一个新数组，然后是第二个数组的所有值，然后是剩下的第一。还要求这是通过动态分配的数组来完成的。我不明白为什么，但由于某种原因，堆正在损坏，我不明白为什么。我刚刚开始学习指针，所以我找到的解决方案对我来说意义不大。

如果有人能准确指出我做错了什么，并向我解释，以便我从错误中吸取教训，我将不胜感激。谢谢！

#include <stdlib.h>
#include <iostream>
#include <time.h>

int* createArray(int);
int* splice(int[], int[], int, int, int);
void arrayPrint(int []);

using namespace std;

int main(void)
{
    int firstLength, secondLength, copyLength;

    cout << "Enter the length of the first array: ";
    cin >> firstLength;
    cout << "Enter the length of the second array: ";
    cin >> secondLength;
    cout << "Enter the length of the first array to be copied: ";
    cin >> copyLength;

    int* firstArray;
    int* secondArray;
    int* thirdArray;

    srand(100);

    firstArray = createArray(firstLength);
    secondArray = createArray(secondLength);

    firstArray = new int[firstLength];
    for (int i = 0; i < firstLength; i++)
        firstArray[i] = rand() % 100;
    secondArray = new int[secondLength];
    for (int i = 0; i < secondLength; i++)
        secondArray[i] = rand() % 100;

    thirdArray = splice(firstArray, secondArray, firstLength, secondLength, copyLength);

    cout << "First Array: " << endl;
    for (int i = 0; i < firstLength; i++)
    {
        cout << firstArray[i] << ", ";
    }
    arrayPrint(firstArray);
    cout << endl << "Second Array: " << endl;
    for (int i = 0; i < secondLength; i++)
    {
        cout << secondArray[i] << ", ";
    }
    arrayPrint(secondArray);
    cout << endl << "Spliced Array: " << endl;
    arrayPrint(thirdArray);

    delete firstArray;
    delete secondArray;
    delete thirdArray;
    system("pause");
    return 0;
}

int* createArray(int arrayLength)
{
    int* createdArray;
    createdArray = new int[arrayLength];
    for (int i = 0; i < arrayLength; i++)
        createdArray[i] = rand();
    return createdArray;
}

int* splice(int firstArray[], int secondArray[], int firstLength, int secondLength, int copyLength)
{
    int* splicedArray;
    splicedArray = new int[copyLength];
    for (int i = 0; i < copyLength; i++)
    {
        splicedArray[i] = firstArray[i];
    }
    for (int j = 0; j < secondLength; j++)
    {
        splicedArray[j + copyLength] = secondArray[j];
    }
    for (int k = 0; k < firstLength - copyLength; k++)
    {
        splicedArray[k + copyLength + secondLength] = firstArray[k + copyLength];
    }
    return splicedArray;
}

void arrayPrint(int toPrint[])
{
    for (int i = 0; i < sizeof(toPrint) / sizeof(*toPrint); i++)
    {
        if ((i % 10) == 9)
            cout << toPrint[i] << endl;
        else
            cout << toPrint[i] << ", ";
    }
}

Answer 1

结合C_Raj的回答，vinodsaluja和Wander3r的评论：

你分配了第一个和第二个数组两次，一次就够了，实际上更多是内存泄漏（vinodsaluja）。从逻辑上讲，由于 thirarray 是第一个和第二个数组的组合，它的长度应该是两个数组长度的总和，即 firstlength + secondlength 而不是复制长度。这是发生堆损坏的地方 (vinodsaluja)。最后应使用 delete[] (Wander3r) 释放 ararys。

C_Raj的代码是结果应该是什么，所以我没有复制它。

动态内存分配和堆损坏

Dynamic Memory Allocation and Heap Corruption

c++

arrays

pointers

heap-memory

dynamic-memory-allocation