禁止特定的 http 方法

Question

与 https://github.com/openzipkin/zipkin/pull/3239 相关，我们遇到了一些（可能）奇怪的行为，我想知道下面的测试是否按预期工作：

import com.linecorp.armeria.client.WebClient;
import com.linecorp.armeria.common.HttpMethod;
import com.linecorp.armeria.common.HttpRequest;
import com.linecorp.armeria.common.HttpResponse;
import com.linecorp.armeria.common.HttpStatus;
import com.linecorp.armeria.server.Server;
import com.linecorp.armeria.server.ServerBuilder;
import java.util.concurrent.CompletableFuture;
import org.junit.jupiter.api.Test;

import static org.assertj.core.api.Assertions.assertThat;

public class ArmeriaTraceBug {

  @Test
  public void test_trace_bug() throws Exception {
    ServerBuilder sb = Server.builder();
    sb.http(7003);
    sb.service("/", (ctx, req) -> HttpResponse.of("Hello, world!"));
    sb.routeDecorator()
      .methods(HttpMethod.TRACE)
      .pathPrefix("/")
      .build((delegate, ctx, req) -> HttpResponse.of(HttpStatus.METHOD_NOT_ALLOWED));
    Server server = sb.build();
    CompletableFuture<Void> future = server.start();
    future.join();
    WebClient webClient = WebClient.of("http://localhost:7003/");
    final HttpResponse response = webClient.execute(HttpRequest.of(HttpMethod.OPTIONS, "/something"));
    assertThat(response.aggregate().get().status()).isEqualTo(HttpStatus.NOT_FOUND);
  }
}

基本上我们想禁用所有 TRACE 请求，并设置 pathPrefix("/") 来实现这一点。但由于某种原因，OPTIONS 对 /something 的调用被困在同一条路径中。如果我删除路由装饰器，一切都会按预期工作。

Answer 1

感谢 Jorg Heymans 提出的问题。是的，这是一个错误，应该由 https://github.com/line/armeria/pull/3120 修复谢谢！

禁止特定的 http 方法

disallowing a particular http method

armeria